refactor!: change raw keyring key_name type to str #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsb42-aws
requested changes
Aug 13, 2020
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| _ENCRYPTION_CONTEXT = {"encryption": "context", "values": "here"} | |||
| _PROVIDER_ID = "Random Raw Keys" | |||
| _KEY_ID = b"5325b043-5843-4629-869c-64794af77ada" | |||
| _KEY_ID = "5325b043-5843-4629-869c-64794af77ada" | |||
There was a problem hiding this comment.
nit: for consistency, let's call this _KEY_NAME (and probably rename _PROVIDER_ID to _KEY_NAMESPACE) since they're substantively different now.
ditto in the raw RSA tests
…ME and _KEY_NAMESPACE
mattsb42-aws
approved these changes
Aug 13, 2020
|
Looks like the check failure is transient, going to re-run checks. |
|
Travis flakiness passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #284
Description of changes: Change the type of the key_name field to str.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: